Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate maintenance scripts #352

Merged
merged 19 commits into from
Oct 15, 2024
Merged

Consolidate maintenance scripts #352

merged 19 commits into from
Oct 15, 2024

Conversation

Brunoga-MS
Copy link
Contributor

@Brunoga-MS Brunoga-MS commented Sep 30, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Add a consolidated script encompassing tasks done from all the previous separated scripts
  2. Add the ability to look for and remove orphaned AMBA-ALZ alerts
  3. Updated documentation with the new script
image image

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@arjenhuitema arjenhuitema self-assigned this Oct 2, 2024
@arjenhuitema arjenhuitema added Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Oct 2, 2024
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Brunoga-MS, the overall direction seems promising.

I recommend dividing the PolicyItems into Assignments and Definitions. Additionally, in the event of a breaking change update, it would be beneficial to support removal on a per-assignment basis, thereby removing only the impacted assignment(s).

Let's update the documentation to incorporate the new script. Also, consider how this approach could assist in streamlining the update documentation.

@Brunoga-MS
Copy link
Contributor Author

@arjenhuitema done .. I also make a pass through Acrolinx. I just couldn't test the rendering since looks like HUGO is not working because of something wrong with D:\Sviluppo\azure-monitor-baseline-alerts\services\AVS\privateClouds_index.md:7:1 and "D:\Sviluppo\azure-monitor-baseline-alerts\docs\layouts\partials\templates\template-tabs.html

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit f6b9cba into Azure:main Oct 15, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants