-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate maintenance scripts #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Brunoga-MS, the overall direction seems promising.
I recommend dividing the PolicyItems into Assignments and Definitions. Additionally, in the event of a breaking change update, it would be beneficial to support removal on a per-assignment basis, thereby removing only the impacted assignment(s).
Let's update the documentation to incorporate the new script. Also, consider how this approach could assist in streamlining the update documentation.
@arjenhuitema done .. I also make a pass through Acrolinx. I just couldn't test the rendering since looks like HUGO is not working because of something wrong with D:\Sviluppo\azure-monitor-baseline-alerts\services\AVS\privateClouds_index.md:7:1 and "D:\Sviluppo\azure-monitor-baseline-alerts\docs\layouts\partials\templates\template-tabs.html |
…or cleanItems parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
As part of this Pull Request I have
main
branch