Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitHub Actions workflow for security compliance requirements #358

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

arjenhuitema
Copy link
Contributor

Overview/Summary

Due to security compliance requirements, we've made core changes that mean we no longer automatically build the policies, initiatives templates after changes are committed.

Updates will need to applied manually by running one or more of the following commands:

bicep build .\patterns\alz\templates\policies-Automation.bicep --outfile .\patterns\alz\policyDefinitions\policies-Automation.json
bicep build .\patterns\alz\templates\policies-Compute.bicep --outfile .\patterns\alz\policyDefinitions\policies-Compute.json
bicep build .\patterns\alz\templates\policies-Hybrid.bicep --outfile .\patterns\alz\policyDefinitions\policies-Hybrid.json
bicep build .\patterns\alz\templates\policies-KeyManagement.bicep --outfile .\patterns\alz\policyDefinitions\policies-KeyManagement.json
bicep build .\patterns\alz\templates\policies-Monitoring.bicep --outfile .\patterns\alz\policyDefinitions\policies-Monitoring.json
bicep build .\patterns\alz\templates\policies-Network.bicep --outfile .\patterns\alz\policyDefinitions\policies-Network.json
bicep build .\patterns\alz\templates\policies-NotificationAssets.bicep --outfile .\patterns\alz\policyDefinitions\policies-NotificationAssets.json
bicep build .\patterns\alz\templates\policies-RecoveryServices.bicep --outfile .\patterns\alz\policyDefinitions\policies-RecoveryServices.json
bicep build .\patterns\alz\templates\policies-ServiceHealth.bicep --outfile .\patterns\alz\policyDefinitions\policies-ServiceHealth.json
bicep build .\patterns\alz\templates\policies-Storage.bicep --outfile .\patterns\alz\policyDefinitions\policies-Storage.json
bicep build .\patterns\alz\templates\policies-Web.bicep --outfile .\patterns\alz\policyDefinitions\policies-Web.json
bicep build .\patterns\alz\templates\policySets.bicep --outfile .\patterns\alz\policyDefinitions\policySets.json

This PR fixes/adds/changes/removes

  1. Removes the automation workflow.

Breaking Changes

None.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@arjenhuitema arjenhuitema added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Oct 3, 2024
Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the need to stop it because of MSRC case explained in the Workitem #37611

@Brunoga-MS Brunoga-MS merged commit ecebd8f into main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants