Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new remediation script that will work with sovereign clouds #373

Closed
wants to merge 6 commits into from

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fixes an issue where the remediation script does not work with AzureGov since the URI called to retrieve the policyDefinitions and the policySetDefinitions is different
  2. The fix has been added to a new version of the script that aligns with the new consolidated maintenance script name.

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script looks solid. However I suggest we add this functionality to the existing script as it's virtually the same.

@arjenhuitema arjenhuitema self-assigned this Oct 15, 2024
@arjenhuitema arjenhuitema added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Oct 15, 2024
@Brunoga-MS Brunoga-MS marked this pull request as draft October 15, 2024 16:13
@Brunoga-MS Brunoga-MS marked this pull request as ready for review October 15, 2024 16:51
@Brunoga-MS Brunoga-MS closed this Dec 10, 2024
@Brunoga-MS Brunoga-MS deleted the AMBA-ALZ-RemediationScript branch December 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants