Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugged Connectivity policy initiative + override tag name case consistency + tag override documentation update #381

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fixes an issue with VNETGbandwidth where the threshold param was passed in wrong way
  2. Enforces case consistency for override tag name
  3. *Adds missing params to Deploy-Connectivity-Alerts policySetDefinition. This bug was reported by customer in [Question/Feedback]: Cannot Deploy AMBA #379 *

image

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS linked an issue Oct 16, 2024 that may be closed by this pull request
1 task
@Brunoga-MS Brunoga-MS added bug Something isn't working Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Oct 16, 2024
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I updated the versioning to a patch for the Override changes since it's just a string update. Please double-check the disconnected alert query.

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit f530689 into Azure:main Oct 17, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question/Feedback]: Cannot Deploy AMBA
2 participants