Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for log alerts policy remediation not working when ALZMonitorDisableTagName parameter value contains dashes #400

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Bug with tag names containing dashes. See issue [Question/Feedback]: Deploy LA Workspace Daily Cap Limit Reached Alert remediation fails #372

before the fix the remediation was failing with this error:

'where' operator: Failed to resolve scalar expression named 'Disable'. A semantic error occurred

after the fix
image

the remediation is successful and the query will have the tag name managed and translated correctly

image

image

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS requested a review from tagolovina October 31, 2024 16:07
@JoeyBarnes JoeyBarnes added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Oct 31, 2024
@Brunoga-MS
Copy link
Contributor Author

Hey @tagolovina , any news with this PR?

Copy link
Contributor

@tagolovina tagolovina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@tagolovina tagolovina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Brunoga-MS Brunoga-MS merged commit 1d002ce into Azure:main Nov 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question/Feedback]: Deploy LA Workspace Daily Cap Limit Reached Alert remediation fails
3 participants