Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 42 (31506) role assignment cleanup #44

Merged

Conversation

mbrat2005
Copy link
Contributor

Overview/Summary

Fixes to Role Assignment cleanup, cleanup script

This PR fixes/adds/changes/removes

  1. Moved Role Assignment cleanup to Resource Graph, simplifying cleanup query to make it work if Policy Assignments were removed
  2. Fixed issue with duplicate resource ID where Resource Graph returns results at parent and child scopes (Get-Unique workaround)
  3. Aligned Policy Assignments query with other queries (now that $policyAssignments is unnecessary)

Breaking Changes

  1. None

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM ... I would just put the various select on the same line they should belong to (i.e., instruction on line 104 should be at the end of line 103. Same for line 109, 119, 124, 129

@arjenhuitema arjenhuitema linked an issue Oct 23, 2023 that may be closed by this pull request
1 task
@arjenhuitema arjenhuitema added the bug Something isn't working label Oct 23, 2023
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know when it´s ready to merge.

@Brunoga-MS
Copy link
Contributor

@arjenhuitema : ready to be merged on my side

@mbrat2005 mbrat2005 marked this pull request as ready for review October 25, 2023 14:13
@arjenhuitema arjenhuitema merged commit f47643d into Azure:main Oct 25, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Start-AMBACleanup is not removing role assignment
3 participants