Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed param file link in Update Customize-Policy-Assignment.md #440

Closed
wants to merge 1 commit into from

Conversation

tagolovina
Copy link
Contributor

Overview/Summary

Changed param file link, fixed the following issue #437

This PR fixes/adds/changes/removes

  1. Fixes issue Documentation link broken #437
  2. Changes link to param file in Customize-Policy-Assignment.md to point to the correct branch.

Breaking Changes

NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Changed param file link, fix the following issue #437
Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets leave it pointing to main for now. When Pat will finish her PR on docu, we will have 2 pointers: one for main and one for release version (always pointing to the latest release) of param file

@Brunoga-MS Brunoga-MS linked an issue Nov 29, 2024 that may be closed by this pull request
Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagolovina ,
given the PR from Patrisia been approved, could you please ensure you add the necessary changes to the correct file in the new path? You might need to sync your repo first. Moreover I would also encourage you to look at the file docs\content\patterns\alz\HowTo\deploy\parameterConfiguration.md where do we call 2 different param file versions ... this should bring more clarity.

@Brunoga-MS
Copy link
Contributor

@tagolovina : given the last documentation update this one is no longer necessary. I am going to close it

@Brunoga-MS Brunoga-MS closed this Dec 9, 2024
@Brunoga-MS Brunoga-MS removed a link to an issue Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants