Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added baseline alerts for oracle on azure iaas #449

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

jessiehaessler
Copy link

@jessiehaessler jessiehaessler commented Dec 6, 2024

Overview/Summary

added Oracle on Azure IaaS baseline alerts.

This PR fixes/adds/changes/removes

added oracle on azure iaas baseline alerts

Breaking Changes

  1. Replace me
  2. Replace me

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jessiehaessler
Copy link
Author

#assign-reviewer:kisshetty

@jessiehaessler jessiehaessler changed the title Jhaessler amba oracle added baseline alerts for oracle on azure iaas Dec 6, 2024
@judyer28 judyer28 requested a review from sblair01 December 6, 2024 19:46
Copy link

@sblair01 sblair01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessiehaessler please see my comments around language and tone. Thresholds make sense to me.

Copy link

@sblair01 sblair01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the quick turnaround time
cc @judyer28

@judyer28
Copy link
Contributor

@jessiehaessler, please fix Lint errors. Looks like line 35 in oracle on azure iaas/_index.md is missing a '|' at the end.

@jessiehaessler
Copy link
Author

@judyer28 fixed the lint issues. Ready to go now.

@judyer28 judyer28 self-requested a review December 18, 2024 12:40
Copy link
Contributor

@judyer28 judyer28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyer28 judyer28 merged commit 8dbebda into Azure:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants