-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added baseline alerts for oracle on azure iaas #449
Conversation
#assign-reviewer:kisshetty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessiehaessler please see my comments around language and tone. Thresholds make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the quick turnaround time
cc @judyer28
@jessiehaessler, please fix Lint errors. Looks like line 35 in oracle on azure iaas/_index.md is missing a '|' at the end. |
@judyer28 fixed the lint issues. Ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
added Oracle on Azure IaaS baseline alerts.
This PR fixes/adds/changes/removes
added oracle on azure iaas baseline alerts
Breaking Changes
As part of this Pull Request I have
main
branch