Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBA Service Health Granular Deployment Flexibility #45

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Adding parameter to provide flexibility to enable/disable SH alerts for:

  • ServiceHealth-Health
  • ServiceHealth-Incident
  • ServiceHealth-Maintenance
  • ServiceHealth-Security

in line with AMBA Service Health Granular Deployment Flexibility user story

This PR fixes/adds/changes/removes

  1. Added parameters to the parameter file
  2. Added policyEffect and effect parameter to the policySetDefinitions file
  3. Added effect parameter to the alert files

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@arjenhuitema
Copy link
Contributor

LGTM @Brunoga-MS, great work!

Can you include some evidence of:

  • The deployment,
  • The resulting changes to the policyDefinitions and policySetDefinitions

Thanks!

@Brunoga-MS
Copy link
Contributor Author

@arjenhuitema : let me know if this is ok

image

image

image

@arjenhuitema arjenhuitema self-assigned this Oct 25, 2023
@arjenhuitema arjenhuitema added the enhancement New feature or request label Oct 25, 2023
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Bruno, great work!

@arjenhuitema arjenhuitema merged commit 1b7c240 into Azure:main Oct 25, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants