Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds terraform-sync parameters #452

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Dec 9, 2024

Overview/Summary

Adds parameter file for TF sync process.

ALZ Library PR for reference: Azure/Azure-Landing-Zones-Library#93

This PR fixes/adds/changes/removes

  1. Adds parameter file for TF sync process.

Breaking Changes

None

Evidence

Used by: platform\amba-alz\scripts\Invoke-LibraryUpdatePolicyAssignmentArchetypes.ps1 in https://github.com/Azure/Azure-Landing-Zones-Library

Workflow:

image

Tasks that call the script, that calls the TF params:

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@arjenhuitema arjenhuitema added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Dec 9, 2024
Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... as a possible enhancement, I would suggest a workflow to automate the update or to flag the need for update (similar to the policies*.json files) when the alzArm.param.json file is updated

@Brunoga-MS Brunoga-MS merged commit ac756ca into Azure:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants