Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property name case consistency and remediation script rename #455

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

Brunoga-MS
Copy link
Contributor

@Brunoga-MS Brunoga-MS commented Dec 9, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fixes consistency in property name [General workload issue]: policies-Network.json contains 'Category' (uppercase) resulting in 'unknown' category #443
  2. Renames the cleanup script to be aligned with the maintenance one
  3. Updates corresponding documentation

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Dec 9, 2024
@Brunoga-MS Brunoga-MS requested a review from tagolovina December 9, 2024 21:45
@Brunoga-MS Brunoga-MS changed the title case consistency and remediation script Property name case consistency and remediation script rename Dec 9, 2024
Copy link
Contributor

@tagolovina tagolovina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brunoga-MS , There is old script name in docs\content\patterns\alz\Overview\Whats-New.md Line 171

@Brunoga-MS
Copy link
Contributor Author

@Brunoga-MS , There is old script name in docs\content\patterns\alz\Overview\Whats-New.md Line 171

@tagolovina: this should not be an issue since that reference is about an old release where the file name remained old

Copy link
Contributor

@tagolovina tagolovina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed it to test environment, empty category issue is fixed. Renamed remediation script works.

@Brunoga-MS Brunoga-MS merged commit 8f5d372 into Azure:main Dec 10, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
2 participants