Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featire updateprocessupdate #456

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

Alboroni
Copy link
Contributor

Overview/Summary

Update to allow deployment of multiple alert processing rules based on different severity in the same subscription.

This PR fixes/adds/changes/removes

Adds to Deploy-AlertProcessingRule-Deploy.json and Deploy-Notification-Assets.json
Screenshot 2024-12-10 122005

Breaking Changes

None - We are adding two more parameters one for selecting the alert severity and one to changing the alert processing rule and description to avoid policy compliance issues

As part of this Pull Request I have

  • [x ] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ x] Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • [x ] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Alboroni Alboroni requested a review from Brunoga-MS December 10, 2024 12:20
Copy link
Contributor

@Brunoga-MS Brunoga-MS Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alboroni : Added params for both Suffix and Severity to the param file

Copy link
Contributor

@Brunoga-MS Brunoga-MS Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alboroni : Added params for both Suffix and Severity to the new terraform-sync param file

Copy link
Contributor

@Brunoga-MS Brunoga-MS Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alboroni :

  • Renamed the suffix param
  • Updated the policySetDefinition version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alboroni : changed the display name of suppression APR to differentiate from the other and to be able to start at 1 in case of future evolutions

Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alboroni : I was able to resolve all the conflicts and to make other changes directly into your branch. I also left some comments on something I changed/fixed/added. Please give it another try and let me know. What I am also thinking about is: why don't we create one APR per severity so customer can decide to disable the one(s) they do not need?

@Brunoga-MS Brunoga-MS added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a parameter for conditions that determine when the Alert Processing Rule should trigger
2 participants