-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featire updateprocessupdate #456
base: main
Are you sure you want to change the base?
Conversation
…ZProcessingRuleNameSuffix and increment versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alboroni : Added params for both Suffix and Severity to the param file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alboroni : Added params for both Suffix and Severity to the new terraform-sync param file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Renamed the suffix param
- Updated the policySetDefinition version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alboroni : changed the display name of suppression APR to differentiate from the other and to be able to start at 1 in case of future evolutions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alboroni : I was able to resolve all the conflicts and to make other changes directly into your branch. I also left some comments on something I changed/fixed/added. Please give it another try and let me know. What I am also thinking about is: why don't we create one APR per severity so customer can decide to disable the one(s) they do not need?
Overview/Summary
Update to allow deployment of multiple alert processing rules based on different severity in the same subscription.
This PR fixes/adds/changes/removes
Adds to Deploy-AlertProcessingRule-Deploy.json and Deploy-Notification-Assets.json
Breaking Changes
None - We are adding two more parameters one for selecting the alert severity and one to changing the alert processing rule and description to avoid policy compliance issues
As part of this Pull Request I have
main
branch