Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal accelerator bug #460

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. *Fixes issue [General workload issue]:Deploying only Hybrid will fail due to Management Group ID mismatch #459 when deploying only Hybrid VM or Azure VM alerts"

With the fixed template the deployment completes with no issues

image

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Fixing bug from Steve DiStefano
Fixing logic for assigning value to MG
Reordering to put MG names all together
Setting platform MG to be visible only if need Hybrid and/or Azure VM
Renaming function for scope clarification
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit 7734f13 into Azure:main Dec 16, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General workload issue]:Deploying only Hybrid will fail due to Management Group ID mismatch
2 participants