-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bryanzab/us28627 #68
Bryanzab/us28627 #68
Conversation
… App Gateway policy defs.
…e-alerts into bryanzab/US28627
| Deploy_activitylog_VPNGateway_Delete | [deploy-activitylog-VPNGate-Del.json](../../../services/Network/vpnGateways/Deploy-ActivityLog-VPNG-Del.json) | deployIfNotExists | | ||
| **Policy Name**| **Path to policy json file**| **Policy default effect** | | ||
|-----------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------| | ||
| Deploy_ERCIR_QosDropBitsInPerSecond_Alert | [deploy-ercir_qosdropsbitsin_alert.json](../../../../services/Network/expressRouteCircuits/Deploy-ERCIR-QOSDropsBitsIn-Alert.json) | deployIfNotExists | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links are working now, so i´m wondering why the extra "../" was added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was the only way for me to verify the links in my local copy of the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a meeting with @JoeyBarnes this week to review the markdown linting but also review whether the additional ../ is required when testing locally. I can't get a local copy of hugo locally for some reason to check whether the links work within hugo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Bryan, I reviewed the changes and I just have a question, I see that all links have been modified, however the links are currently working, can you review if this change is required.
…and make sure it uses underscores.
@JoeyBarnes I've gone through the markdown files that have issues with the URLs and they URLs all work, (there were a few that had issues but I've since fixed them. I also tested the links when running the Hugo locally and they work then too. |
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
None
As part of this Pull Request I have
main
branch