Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new release guidance #71

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Update to new release guidance #71

merged 10 commits into from
Nov 14, 2023

Conversation

Brunoga-MS
Copy link
Contributor

@Brunoga-MS Brunoga-MS commented Nov 9, 2023

Overview/Summary

Adding documentation page to update existing deployments to a new release of AMBA

This PR fixes/adds/changes/removes

  1. docs/content/patterns/alz/Update-to-new-Release.md as part of AMBA Create update guidance
  2. related images

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

- Update to new release guidance
- typos discovered
- Adding new image
- Resized Releases.png
- fixing broken link
@arjenhuitema arjenhuitema added the documentation Improvements or additions to documentation label Nov 10, 2023
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bruno! Please review the 3 additional parameter files. It looks like those were from a demo/ test environment, if so please removed them from the PR.

patterns/alz/AMBA_Demo-alzArm.param.json Outdated Show resolved Hide resolved
Copy link
Contributor

@paulgrimley paulgrimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, just need to add consideration for offline deployment

docs/content/patterns/alz/Update-to-new-Release.md Outdated Show resolved Hide resolved
@Brunoga-MS
Copy link
Contributor Author

@paulgrimley , @arjenhuitema: this should be good to go now.

Copy link
Contributor

@paulgrimley paulgrimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, LGTM

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


</br>

### Deploy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What If the customer has a custom parameter file?

@arjenhuitema arjenhuitema merged commit 1124c0b into Azure:main Nov 14, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants