Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts Guidance for Azure Function Apps/ ExpressRoute/ Storage #95

Merged
merged 13 commits into from
Jan 12, 2024

Conversation

cassiekays
Copy link
Contributor

@cassiekays cassiekays commented Dec 15, 2023

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Replace me
  2. Replace me
  3. Replace me

Breaking Changes

  1. Replace me
  2. Replace me

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@cassiekays cassiekays marked this pull request as ready for review January 8, 2024 20:07
@cassiekays
Copy link
Contributor Author

@JoeyBarnes , ready for review :)

Copy link
Contributor

@judyer28 judyer28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cassiekays the _index.md files for each section need to have the "geekdocHidden: true" removed. In your reference links, please remove the "/en-us" section of the URL so that the link will be translated to the language of the person browsing the link. Lastly, the metric names should be as they are defined in the metrics referenced here: https://learn.microsoft.com/azure/azure-monitor/reference/supported-metrics/microsoft-web-sites-metrics. For example, the name field can be "Data In" but the metricName should still be "BytesReceived." Please update so that the metric names match the reference docs.

@cassiekays cassiekays changed the title Alerts Guidance for Azure Function App/ Web Apps Alerts Guidance for Azure Function Apps/ ExpressRoute/ Storage Jan 12, 2024
@judyer28 judyer28 merged commit fc8924e into Azure:main Jan 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants