Union #818 #821 #822 #823
Draft
Union #818 #821 #822 #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…installation On a freshly configured system (VM/container/server) the apt cache may not be populated. This causes any remediation task that requires package installation to happen to fail. Ensure we update the package cache on the first invocation of a function that attempts to install a package.
jepio
force-pushed
the
union-818-821-822
branch
from
22700c1
to
10e145f
Compare
4 tasks
AhmedBM
reviewed
Nov 27, 2024
| ) | ||
|
|
AhmedBM
reviewed
Nov 27, 2024
|
|
||
| set(SRC ${moduletest_SOURCE_DIR}/recipes) | ||
| set(MOF1 ${OsConfigResourceSsh_SOURCE_DIR}/LinuxSshServerSecurityBaseline.mof) |
There was a problem hiding this comment.
a CMake list might be better here as the list grows...
eg.
set(MOFS
${OsConfigResourceSsh_SOURCE_DIR}/LinuxSshServerSecurityBaseline.mof
${OsConfigResourceAsb_SOURCE_DIR}/AzureLinuxBaseline.mof
)
list(JOIN MOF_LIST " " flat_string)
add_custom_command(
OUTPUT ${SRC}/SecurityBaselineTests.json
DEPENDS ${SRC}/create-asb-json.sh ${SRC}/mof-to-json.awk ${SRC}/SecurityBaselineTests.json-header ${SRC}/SecurityBaselineTests.json-mid ${SRC}/SecurityBaselineTests.json-footer ${MOF1} ${MOF2}
COMMAND ./create-asb-json.sh ${MOF_LIST} >${SRC}/SecurityBaselineTests.json
WORKING_DIRECTORY ${SRC}
)
No hurry, I also wanted to file an issue with more context for the selinux context problem.
I was actually thinking the opposite - use this one just to demonstrate passing CI but review/merge the individual PRs. @AhmedBM could you rerun the failing test runs? I think they're somehow flaky (todo: investigate). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a merge of:
This is intended to demonstrate that moduletests pass when all three PRs are merged together. Not intended for merging.
Checklist
mainbranch prior to this PR submission.mainbranch.