Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken authentication check in azure-ai-projects #38690

Open
wants to merge 2 commits into
base: feature/azure-ai-projects-b2
Choose a base branch
from
Open

Fix broken authentication check in azure-ai-projects #38690

wants to merge 2 commits into from

Conversation

adrianmo
Copy link
Member

@adrianmo adrianmo commented Nov 25, 2024 •
edited
Loading

Description

Fixed the conditional check to use in instead of == to correctly handle multiple authentication types.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the AI label Nov 25, 2024
@adrianmo adrianmo marked this pull request as ready for review November 25, 2024 15:15
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@adrianmo adrianmo changed the base branch from main to feature/azure-ai-projects-b2 November 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigiw luigiw Awaiting requested review from luigiw luigiw is a code owner

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@achauhan-scc achauhan-scc Awaiting requested review from achauhan-scc achauhan-scc is a code owner

@kingernupur kingernupur Awaiting requested review from kingernupur kingernupur is a code owner

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

@dargilco dargilco Awaiting requested review from dargilco dargilco is a code owner

@jhakulin jhakulin Awaiting requested review from jhakulin jhakulin is a code owner

@jayesh-tanna jayesh-tanna Awaiting requested review from jayesh-tanna jayesh-tanna is a code owner

Assignees
No one assigned
Labels
AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianmo @azure-sdk