Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for mlflow py312 environment #3607

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added unit tests for mlflow py312 environment #3607

wants to merge 8 commits into from

Conversation

Tarun-Chevula
Copy link
Contributor

Added unit tests for mlflow py312 environment

@Tarun-Chevula Tarun-Chevula requested a review from a team as a code owner November 19, 2024 12:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Test Results for assets-test

2 tests   0 ✅  4s ⏱️
2 suites  0 💤
2 files    2 ❌

For more details on these failures, see this check.

Results for commit 287ca07.

♻️ This comment has been updated with latest results.

vizhur
vizhur reviewed Nov 26, 2024
View reviewed changes
assets/inference/environments/mlflow-ubuntu22.04-py312-cpu-inference/tests/mlflow_test.py Outdated

env_docker_context = Environment(
build=BuildContext(path=this_dir / BUILD_CONTEXT),
name="minimal_cpu_inference",
description="minimal 22.04 py312 cpu inference environment created from a Docker context.",
name="mlflow_py312_inference",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should be name=env_name

vizhur
vizhur reviewed Nov 26, 2024
View reviewed changes
assets/inference/environments/mlflow-ubuntu22.04-py312-cpu-inference/tests/mlflow_test.py Outdated
score="valid_score.py",
score="/var/mlflow_resources/mlflow_score_script.py",
score_input="sample_2_0_input.txt",
model_dir="mlflow_2_0_model_folder"
),
environment=f"{env_name}@latest",
Copy link
Contributor

@vizhur vizhur Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ml_client.Environment.create_or_update returns an instance of environment. Please pass it to the common job instead of trying resolve the latest label based on the assumption it was created above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vizhur vizhur vizhur requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tarun-Chevula @vizhur