Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support azapi v2 and improve test coverage #81

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Dec 11, 2024

Description

Support for azapi v2

Improve test coverage for DNS zones and BYO networking.

Related to #71

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 25 out of 34 changed files in this pull request and generated no suggestions.

Files not reviewed (9)
  • examples/azure_devops_basic/main.tf: Language not supported
  • examples/azure_devops_bring_your_own_vnet/main.tf: Language not supported
  • examples/azure_devops_bring_your_own_vnet_and_dns_zone/main.tf: Language not supported
  • examples/azure_devops_container_instance/main.tf: Language not supported
  • examples/azure_devops_public_networking/main.tf: Language not supported
  • examples/azure_devops_bring_your_own_vnet/README.md: Evaluated as low risk
  • examples/azure_devops_basic/README.md: Evaluated as low risk
  • examples/azure_devops_bring_your_own_vnet_and_dns_zone/README.md: Evaluated as low risk
  • examples/azure_devops_bring_your_own_vnet_and_dns_zone/_footer.md: Evaluated as low risk
@jaredfholgate jaredfholgate merged commit c140f2f into main Dec 11, 2024
19 checks passed
@jaredfholgate jaredfholgate deleted the chore-test-more-options branch December 11, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants