Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS Services Client to latest version #389

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Haard30
Copy link
Contributor

@Haard30 Haard30 commented Jun 13, 2024

We last updated the Microsoft.VisualStudio.Services.Client version more than year ago. We have received couple of bug reports in past few months where the client fails to fetch the list of active PATs for a user. For example see the below stack trace,

Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.HandleResponseAsync(HttpResponseMessage response, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync(HttpRequestMessage message, HttpCompletionOption completionOption, Object userState, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpRequestMessage message, Object userState, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpMethod method, IEnumerable`1 additionalHeaders, Guid locationId, Object routeValues, ApiResourceVersion version, HttpContent content, IEnumerable`1 queryParameters, Object userState, CancellationToken cancellationToken)
at Microsoft.Authentication.AdoPat.TokensHttpClientWrapper.ListPatsAsync(Nullable`1 displayFilterOption, Nullable`1 sortByOption, Nullable`1 isSortAscending, String continuationToken, Nullable`1 top, Object userState, CancellationToken cancellationToken) in D:\a\microsoft-authentication-cli\microsoft-authentication-cli\src\AdoPat\TokensHttpClientWrapper.cs:line 52
at Microsoft.Authentication.AdoPat.PatClient.ListActiveAsync(CancellationToken cancellationToken) in D:\a\microsoft-authentication-cli\microsoft-authentication-cli\src\AdoPat\PatClient.cs:line 75

We should first update our client to latest version so we can reach out to ADO team if the issue persists while using this new version.

Testing

  1. Publish new version locally.
  2. Run all the ado pat commands with various scopes.
  3. Delete cache and re -run pat commands.
  4. Do the above for both mac and windows.

@Haard30 Haard30 marked this pull request as ready for review June 13, 2024 20:46
@Haard30 Haard30 requested a review from a team as a code owner June 13, 2024 20:46
@Haard30 Haard30 merged commit ab1d029 into main Jun 13, 2024
9 checks passed
@Haard30 Haard30 deleted the user/haashah/update-vs-client branch June 13, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants