Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: Embed FREISA landing page using absolute URL #21

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[FIX]: Embed FREISA landing page using absolute URL #21

merged 1 commit into from
Oct 31, 2023
+1 −1

Conversation

gmacario
Copy link
Member

@gmacario gmacario commented Oct 31, 2023 •
edited
Loading

📑 Description

Relative URL does not look correct when displayed as https://github.com/B-AROL-O

Fix #20

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@gmacario
Embed FREISA landing page using absolute URL
e89f925 
Relative URL does not look correct when displayed as https://github.com/B-AROL-O

Fix #20
@gmacario gmacario linked an issue Oct 31, 2023 that may be closed by this pull request
[BUG]: Link to 2023-10-28-freisa-landing-page.png is broken #20
Closed
@gmacario gmacario self-assigned this Oct 31, 2023
@gmacario gmacario added bug Something isn't working documentation Improvements or additions to documentation labels Oct 31, 2023
@gmacario gmacario added this to the dev-cw44 milestone Oct 31, 2023
@gmacario gmacario requested a review from alv67 October 31, 2023 18:49
alv67
alv67 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@alv67 alv67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alv67 alv67 merged commit 7daec82 into main Oct 31, 2023
4 checks passed
@alv67 alv67 deleted the 20-bug-link-to-2023-10-28-freisa-landing-pagepng-is-broken branch October 31, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alv67 alv67 alv67 approved these changes

Assignees

@gmacario gmacario

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
2023-cw44
Development

Successfully merging this pull request may close these issues.

[BUG]: Link to 2023-10-28-freisa-landing-page.png is broken
2 participants
@gmacario @alv67