Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update super linter version (v5 -> v7) #46

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

davmacario
Copy link
Member

@davmacario davmacario commented Oct 5, 2024

Closes #44

πŸ“‘ Description

Update Super Linter from version 5(slim) to version 7(slim).
Also formatted the .github/workflows/linter.yml file.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

N.A.

@davmacario davmacario added the enhancement New feature or request label Oct 5, 2024
@davmacario davmacario requested a review from gmacario October 5, 2024 08:37
@davmacario davmacario self-assigned this Oct 5, 2024
Copy link
Member

@gmacario gmacario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davmacario thank you for your contribution. Unfortunately it looks like additional changes are needed to make the build green:

image

@davmacario
Copy link
Member Author

Unfortunately it looks like additional changes are needed to make the build green

Yep, I'm creating some config files for the linters - stuff like JSCPD uses default configuration values that are causing issues.

@davmacario
Copy link
Member Author

I also realized that for how GitHub Actions are configured (triggered on push - for non-main branches - and on PR), this causes 2 actions to run at the same time when pushing to a branch for which there is a PR open.

Is this wanted?

@davmacario
Copy link
Member Author

@gmacario the checks are now passed.

I chose to remove some of the linters because I deemed them "too much" for this project - let me know if you have any feedback on this.

Also, let me know about the problem with duplicate jobs.

@davmacario
Copy link
Member Author

To solve the duplicate job issue, I propose something like:

job:
    lint:
        ...
        if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository
        ...

@gmacario
Copy link
Member

gmacario commented Oct 7, 2024

To solve the duplicate job issue, I propose something like:

LGTM. Maybe you could file the duplicate runs as a separate bug, then create another PR πŸ˜‰

@gmacario gmacario self-requested a review October 7, 2024 06:44
@gmacario gmacario merged commit 4e8c741 into main Oct 7, 2024
3 checks passed
@davmacario
Copy link
Member Author

I will also improve the devcontainer setup - maybe with automatic pip package installations upon launch.

@gmacario gmacario deleted the ci/update-super-linter branch October 7, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Update to a newer version of Super-Linter
2 participants