-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update super linter version (v5 -> v7) #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davmacario thank you for your contribution. Unfortunately it looks like additional changes are needed to make the build green:
Yep, I'm creating some config files for the linters - stuff like JSCPD uses default configuration values that are causing issues. |
I also realized that for how GitHub Actions are configured (triggered on push - for non-main branches - and on PR), this causes 2 actions to run at the same time when pushing to a branch for which there is a PR open. Is this wanted? |
@gmacario the checks are now passed. I chose to remove some of the linters because I deemed them "too much" for this project - let me know if you have any feedback on this. Also, let me know about the problem with duplicate jobs. |
To solve the duplicate job issue, I propose something like: job:
lint:
...
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository
... |
LGTM. Maybe you could file the duplicate runs as a separate bug, then create another PR π |
I will also improve the devcontainer setup - maybe with automatic pip package installations upon launch. |
Closes #44
π Description
Update Super Linter from version 5(slim) to version 7(slim).
Also formatted the
.github/workflows/linter.yml
file.β Checks
βΉ Additional Information
N.A.