-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] ci: fix duplicate jobs #48
Conversation
@gmacario I am open to suggestions :) |
Maybe reading the examples at https://github.com/super-linter/super-linter could help |
Concerning
I am quite sure you are familiar with https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/manually-running-a-workflow, aren't you? |
I am now, and the documentation for the
Indeed, despite having pushed changes that add the |
@davmacario Re:
Although this feature is quite welcome, I would suggest to handle that in a separate PR since it is not related to bug #47 which this PR is supposed to fix |
@gmacario should work now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the caveat which I mentioned in #48 (comment)
@davmacario Re:
- Create new job to build and push Depthai Docker image to the GitHub Container Registry (to be tested)
Although this feature is quite welcome, I would suggest to handle that in a separate PR since it is not related to bug #47 which this PR is supposed to fix
LGTM. Merging PR
Closes #47
π Description
β Checks
βΉ Additional Information
The PR is still in draft, as I am trying to find a way to test the new job (I am accepting suggestions).
I also would like to trigger the action when, either:
Dockerfile
,requirements.txt
andvision_webserver.py
are changed when pushing (or merging) to mainbut it does not seem to be possible (as I can only define the
push
trigger once). If there was a way to do so, it would also be possible to test this job without having to merge to main first.