Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gmacario solutions to days 04, 05, 06, 07, 08 #7

Merged
merged 14 commits into from
Dec 9, 2024

Conversation

gmacario
Copy link
Member

@gmacario gmacario commented Dec 8, 2024

πŸ“‘ Description

The Title says it all.

Solution for Day 06, Part 2 is still WIP at the moment.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Signed-off-by: Gianpaolo Macario <[email protected]>
Signed-off-by: Gianpaolo Macario <[email protected]>
Signed-off-by: Gianpaolo Macario <[email protected]>
@gmacario gmacario added the enhancement New feature or request label Dec 8, 2024
@gmacario gmacario self-assigned this Dec 8, 2024
@gmacario
Copy link
Member Author

gmacario commented Dec 8, 2024

May I ask some kind fellow team member to please review and merge this PR?

@gmacario gmacario requested a review from OrsoEric December 8, 2024 13:25
Copy link
Member

@davmacario davmacario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is one of the reasons I hate Jupyter Notebooks

@gmacario
Copy link
Member Author

gmacario commented Dec 9, 2024

Thanks for your review @davmacario.
Merging PR

Re:

This PR is one of the reasons I hate Jupyter Notebooks

Could you please elaborate?

@gmacario gmacario merged commit 7d6d37d into main Dec 9, 2024
16 checks passed
@gmacario gmacario deleted the gmacario-days-04-05-06-07-08 branch December 9, 2024 07:35
@davmacario
Copy link
Member

Could you please elaborate?

Git diff: +4880 -0

Lines of useful code ~300

@gmacario
Copy link
Member Author

gmacario commented Dec 10, 2024

Could you please elaborate?

Git diff: +4880 -0

Lines of useful code ~300

Have you ever tried this

jupyter nbconvert --to script 'my-notebook.ipynb'

@gmacario
Copy link
Member Author

... or simply https://github.blog/changelog/2023-03-01-feature-preview-rich-jupyter-notebook-diffs/

This is what you see after you enable this Feature Preview:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants