Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional iconfig options from framework #278

Merged
merged 6 commits into from
Feb 26, 2024
Merged

additional iconfig options from framework #278

merged 6 commits into from
Feb 26, 2024

Conversation

prjemian
Copy link
Contributor

close #250

@prjemian prjemian added the task routine work label Feb 25, 2024
@prjemian prjemian added this to the v1.0.2 milestone Feb 25, 2024
@prjemian prjemian self-assigned this Feb 25, 2024
@coveralls
Copy link

coveralls commented Feb 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8053873790

Details

  • -4 of 8 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 82.66%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bluesky/instrument/framework/initialize.py 4 8 50.0%
Totals Coverage Status
Change from base Build 8053762564: -0.3%
Covered Lines: 982
Relevant Lines: 1188
💛 - Coveralls

MDecarabas
MDecarabas approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prjemian
Copy link
Contributor Author

Thanks!

@prjemian
Copy link
Contributor Author

Still, there are some merge conflicts to resolve.

@prjemian prjemian mentioned this pull request Feb 26, 2024
Merged
@prjemian prjemian merged commit f0991ab into main Feb 26, 2024
@prjemian prjemian deleted the 250-additional-iconfig-options branch February 26, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDecarabas MDecarabas MDecarabas approved these changes

@mdwyman mdwyman Awaiting requested review from mdwyman

@rodolakis rodolakis Awaiting requested review from rodolakis

Assignees

@prjemian prjemian

Labels
task routine work
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.

additional iconfig options from framework
3 participants
@prjemian @coveralls @MDecarabas