Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and combine for EPICS scan_id PV #280

Merged
merged 2 commits into from
Feb 26, 2024
Merged

refactor and combine for EPICS scan_id PV #280

merged 2 commits into from
Feb 26, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the task routine work label Feb 26, 2024
@prjemian prjemian added this to the v1.0.2 milestone Feb 26, 2024
@prjemian prjemian self-assigned this Feb 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8051820387

Details

  • 0 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 82.91%
Totals Coverage Status
Change from base Build 7992012688: 0.3%
Covered Lines: 980
Relevant Lines: 1182
💛 - Coveralls

MDecarabas
MDecarabas approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prjemian
Copy link
Contributor Author

Thanks!

@prjemian prjemian merged commit 846eafc into main Feb 26, 2024
7 checks passed
@prjemian prjemian deleted the 229-setup-scan_id-PV branch February 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDecarabas MDecarabas MDecarabas approved these changes

@mdwyman mdwyman Awaiting requested review from mdwyman

@rodolakis rodolakis Awaiting requested review from rodolakis

Assignees

@prjemian prjemian

Labels
task routine work
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.

refactor and combine for EPICS scan_id PV
3 participants
@prjemian @coveralls @MDecarabas