Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] prevent auto complete search outside the given context #32

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

marmoure
Copy link
Contributor

Fixes #18
This PR will limit the search context and only match the one given

Copy link
Collaborator

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good... just some minor changes to improve clarity please, and some questions about visibility of class members

@adamretter adamretter merged commit 31afb68 into BCDH:master Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom entry lookup searches across multiple contexts
2 participants