Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Code For Netbeans UI designer #40

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

marmoure
Copy link
Contributor

@marmoure marmoure commented Jan 19, 2024

While adding some features we had to do some manual changes which broke the Netbeans UI designer code, this PR should fix that And also Fixes #39 and now should allow for long labels.
image

@@ -96,16 +96,11 @@ public void actionPerformed(java.awt.event.ActionEvent evt) {
jLabel1.setText("Custom lookup");

dependentJLabel.setText("Dependent:");
dependentJLabel.setToolTipText("");

dependentJTextField.addActionListener(new java.awt.event.ActionListener() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove this listener?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay... but why did you decide to remove it?

@@ -84,7 +84,7 @@ private void initComponents() {
restultsJTable = new javax.swing.JTable();

setDefaultCloseOperation(javax.swing.WindowConstants.DISPOSE_ON_CLOSE);
setTitle("Custom lookup");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm... okay, but why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This String is already Set in newSuggestionForm.form And this is now duplicated.

</Component>
<Component class="javax.swing.JButton" name="fetchjButton">
<Properties>
<Property name="text" type="java.lang.String" value="Search"/>
<Property name="text" type="java.lang.String" value="Search..."/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to rename the text on this button?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that? It doesn't seem related to the title of the PR?

@@ -100,35 +99,31 @@
<Property name="font" type="java.awt.Font" editor="org.netbeans.beaninfo.editors.FontEditor">
<Font name="Segoe UI" size="18" style="0"/>
</Property>
<Property name="text" type="java.lang.String" value="Custom Lookup"/>
<Property name="text" type="java.lang.String" value="Custom lookup"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to rename the text of this label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that? It doesn't seem related to the title of the PR?

Copy link
Collaborator

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these changes perhaps aren't meant to be in this PR (or at least the title of the PR doesn't indicate that they should be)

@marmoure
Copy link
Contributor Author

Some of these changes perhaps aren't meant to be in this PR (or at least the title of the PR doesn't indicate that they should be)

Agree, I should have mentioned that while adding some features last time i broke the code for the visual designer, while trying to fix #39 i had to refactor the code a bit.

@marmoure marmoure changed the title Remove the text input hard margin Refactor the Code For Netbeans UI designer Jan 22, 2024
@adamretter adamretter merged commit 517b49f into BCDH:master Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input field cropped in custom lookup dialog when label is long
2 participants