Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 주변 상점 UI 웹, ios와 동기화 #411

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

hsgo2430
Copy link
Contributor

@hsgo2430 hsgo2430 commented Oct 9, 2024

개요

  • 주변 상점 UI 변경
  • 이벤트 배너 수정

작업 상세내용

  • 주변 상점 UI를 웹, IOS와 같도록 동기화
  • 이벤트 배너에 화살표를 넣어 화살표를 통해 배너를 움직일 수 이도록 수정

결과 화면

-주변 상점 UI

-이벤트 배너

@hsgo2430 hsgo2430 requested a review from a team as a code owner October 9, 2024 06:20
@github-actions github-actions bot added the fix label Oct 9, 2024
Copy link
Contributor

@nodobi nodobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 코멘트 확인해주세요 😁

Comment on lines 114 to 135
<EditText
android:id="@+id/search_editText"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_gravity="start|center"
android:background="@null"
android:hint="상점명을 입력하세요"
android:imeOptions="actionDone"
android:includeFontPadding="false"
android:lineSpacingExtra="6sp"
android:maxLines="1"
android:padding="13dp"
android:singleLine="true"
android:textColor="@color/gray9"
android:textSize="13sp"
app:fontName="Custom6"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/search_image_view"
app:layout_constraintHorizontal_bias="0.0"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintVertical_bias="0.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app:fontName 속성은 #330 에서 제거됬어요!

core 모듈 안 text_appearance.xml 에 텍스트 스타일이 정의되어 있으니 피그마에서 사용되는 타이포그래피 기준으로 맞춰서 사용하시면 됩니다!

  android:textAppearance="@style/TextAppearance.Koin.Medium.16"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨겠네요! 감사합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants