feat: 학점 조회 기능 추가 #366
Merged
feat: 학점 조회 기능 추가 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: presigned url 에만 https 프로토콜 적용되도록 수정
daheeParkk
requested changes
Mar 27, 2024
| @@ -231,5 +238,17 @@ public Map<String, Object> deleteTimeTableById(int id) throws Exception { | |||
| }}; | |||
| } | |||
|
|
|||
| private int calculateTotalGrades(int userId){ | |||
There was a problem hiding this comment.
A
Suggested change
| private int calculateTotalGrades(int userId){ | |
| private int calculateTotalGrades(int userId) { |
띄어쓰기 해주면 좋을 것 같아요!
Comment on lines
85
to
86
| put("이번학기학점", currentGrades); | ||
| put("전체학기학점", calculateTotalGrades(user.getId())); |
There was a problem hiding this comment.
C
다른 api처럼 영어로 응답하는게 좋을 것 같아요!
duehee
reviewed
Mar 28, 2024
| Map<String, Object> retMap = new HashMap<String, Object>() {{ | ||
| put("timetable", timetables); | ||
| put("semester", semester); | ||
| put("grades", currentGrades); |
There was a problem hiding this comment.
C
grade보다는 credit을 사용하는 것은 어떨까요? crade는 학점보다는 성적 느낌이 조금 큰 것 같아요!
There was a problem hiding this comment.
감사합니다. 근데 DB에는 이수학점이 grade로 돼있는데.. 관습상 grade로 통일하는건 어떤가요..?
| Map<String, Object> retMap = new HashMap<String, Object>() {{ | ||
| put("timetable", timetables); | ||
| put("semester", semester); | ||
| put("grades", currentGrades); | ||
| put("total_grades", calculateTotalGrades(user.getId())); |
duehee
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
▶ Request
Content
#365
as-is
시간표 조회시 전체학점과 해당학기학점 반환
to-be
TimeTableServiceIml에서 학기조회를 통해 해당 유저의 학점을 계산
✅ Check List
pom.xml) 변경이 일어나지 않았는지📸 API Document ScreenShot
🧪 Test
2개의 학기를 시간표 추가하고 해당학기학점, 전체학기학점를 확인했습니다.