fix: lecutre 테이블 컬럼 수정 #1065
Open
fix: lecutre 테이블 컬럼 수정 #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
requested review from
seongjae6751,
daheeParkk,
kwoo28 and
duehee
kwoo28
requested changes
Nov 20, 2024
src/main/resources/db/migration/V104__alter_lecture_class_semester_fk.sql
Outdated
Show resolved
Hide resolved
kwoo28
approved these changes
Nov 20, 2024
duehee
requested changes
Nov 25, 2024
Comment on lines
+1
to
+2
| ALTER TABLE `koin`.`lectures` | ||
| DROP COLUMN `semester_date`; |
There was a problem hiding this comment.
C
컬럼 삭제..하는 과정에서 flyway 오류가 안 날지 모르겠네용
There was a problem hiding this comment.
흠,, 일단은 컬럼을 삭제하지 않는 방향이 적절할까요..?
지금 그렇게 큰 문제가 되지는 않는 것 같아서, 있어도 그만, 없어도 그만이라고 생각은 듭니다.
Comment on lines
+4
to
+7
| UPDATE `koin`.`lectures` l | ||
| SET `semester_id` = (SELECT `id` | ||
| FROM `koin`.`semester` s | ||
| WHERE l.`semester_date` = s.`semester`); |
There was a problem hiding this comment.
C
DML이랑 DDL이 같이 있네요👀(분리..!!)
추가적으로 최근에 진호님이 PR 올리신 내용이 있어서 한 번 확인해보시는 것도 좋을 거 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항