refactor: 어드민 유저 리팩토링 #1068
Merged
refactor: 어드민 유저 리팩토링 #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
requested changes
Nov 20, 2024
src/main/java/in/koreatech/koin/admin/owner/controller/AdminOwnerController.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/owner/service/AdminOwnerService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/owner/service/AdminOwnerService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/owner/service/AdminOwnerService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/admin/owner/service/AdminOwnerService.java
Outdated
Show resolved
Hide resolved
duehee
approved these changes
Nov 24, 2024
| @ApiResponse(responseCode = "404", content = @Content(schema = @Schema(hidden = true))), | ||
| } | ||
| ) | ||
| @Operation(summary = "회원 정보 수정") |
There was a problem hiding this comment.
A
간단한 거긴한데, 학생 정보 수정으로 하면 좋을 거 같아요
Comment on lines
+49
to
+59
| @Transactional | ||
| public AdminStudentUpdateResponse updateStudent(Integer id, AdminStudentUpdateRequest adminRequest) { | ||
| Student student = adminStudentRepository.getById(id); | ||
| User user = student.getUser(); | ||
| validateNicknameDuplication(adminRequest.nickname(), id); | ||
| validateDepartmentValid(adminRequest.major()); | ||
| user.update(adminRequest.nickname(), adminRequest.name(), | ||
| adminRequest.phoneNumber(), UserGender.from(adminRequest.gender())); | ||
| user.updateStudentPassword(passwordEncoder, adminRequest.password()); | ||
| student.update(adminRequest.studentNumber(), adminRequest.major()); | ||
| adminStudentRepository.save(student); |
There was a problem hiding this comment.
A
제가 이번에 User와 Student를 수정하면서, 메소드 수정할 사항이 좀 생겼어요!!! 리팩토링 끝나고 한 번 다시 정리해도 될까요?
Comment on lines
+63
to
+76
|
|
||
| private void validateNicknameDuplication(String nickname, Integer userId) { | ||
| if (nickname != null && | ||
| adminUserRepository.existsByNicknameAndIdNot(nickname, userId)) { | ||
| throw DuplicationNicknameException.withDetail("nickname : " + nickname); | ||
| } | ||
| } | ||
|
|
||
| private void validateDepartmentValid(String department) { | ||
| if (department != null && !StudentDepartment.isValid(department)) { | ||
| throw StudentDepartmentNotValidException.withDetail("학부(학과) : " + department); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
A
이번에 User팀에서는 ValidationService를 분리했는데, 어떻게 생각하시나요?
| @@ -26,10 +26,10 @@ | |||
|
|
|||
| import in.koreatech.koin.AcceptanceTest; | |||
| import in.koreatech.koin.admin.user.model.Admin; | |||
| import in.koreatech.koin.admin.user.repository.AdminOwnerRepository; | |||
| import in.koreatech.koin.admin.user.repository.AdminOwnerShopRedisRepository; | |||
| import in.koreatech.koin.admin.owner.repository.AdminOwnerRepository; | |||
Soundbar91
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항