Improve hasDimensions command

Seems to make it more stable, like it waits longer
BKWLD · Nov 17, 2023 · ee82388 · ee82388
1 parent 80718a7
commit ee82388
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/packages/next/cypress/support/commands.ts b/packages/next/cypress/support/commands.ts
@@ -4,10 +4,8 @@
 Cypress.Commands.add('hasDimensions',
   { prevSubject: true },
   (subject, width, height) => {
-
-  expect(subject.width()).to.equal(width)
-  expect(subject.height()).to.equal(height)
-  return subject
+  cy.wrap(subject).invoke('width').should('equal', width)
+  cy.wrap(subject).invoke('height').should('equal', height)
 })
 
 // Check that a video is playing
@@ -28,7 +26,7 @@ declare global {
       hasDimensions(
         width: number,
         height: number
-      ): Chainable<JQueryWithSelector>
+      ): Chainable<void>
 
       isPlaying(): Chainable<void>
     }

diff --git a/packages/react/cypress/support/commands.ts b/packages/react/cypress/support/commands.ts
@@ -4,10 +4,8 @@
 Cypress.Commands.add('hasDimensions',
   { prevSubject: true },
   (subject, width, height) => {
-
-  expect(subject.width()).to.equal(width)
-  expect(subject.height()).to.equal(height)
-  return subject
+  cy.wrap(subject).invoke('width').should('equal', width)
+  cy.wrap(subject).invoke('height').should('equal', height)
 })
 
 // Check that a video is playing
@@ -44,7 +42,7 @@ declare global {
       hasDimensions(
         width: number,
         height: number
-      ): Chainable<JQueryWithSelector>
+      ): Chainable<void>
 
       isPlaying(): Chainable<void>
       isPaused(): Chainable<void>

diff --git a/packages/sanity-next/cypress/support/commands.ts b/packages/sanity-next/cypress/support/commands.ts
@@ -4,10 +4,8 @@
 Cypress.Commands.add('hasDimensions',
   { prevSubject: true },
   (subject, width, height) => {
-
-  expect(subject.width()).to.equal(width)
-  expect(subject.height()).to.equal(height)
-  return subject
+  cy.wrap(subject).invoke('width').should('equal', width)
+  cy.wrap(subject).invoke('height').should('equal', height)
 })
 
 // Check that a video is paused
@@ -28,7 +26,7 @@ declare global {
       hasDimensions(
         width: number,
         height: number
-      ): Chainable<JQueryWithSelector>
+      ): Chainable<void>
 
       isPlaying(): Chainable<void>
     }