Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FInish @react-visual/react #31

Merged
merged 29 commits into from
Nov 17, 2023
Merged

FInish @react-visual/react #31

merged 29 commits into from
Nov 17, 2023

Conversation

weotch
Copy link
Member

@weotch weotch commented Nov 17, 2023

Closes #30

weotch added 22 commits October 24, 2023 22:15
@weotch
Move main Visual type declaration into react-visual
ea44a9d
@weotch
Stub out ReactVisual initial tests
7b8b15c
@weotch
Use image and video rendering from next-visual
4053e73
@weotch
Fix type reference
27cc4cd
@weotch
Implement picture rendering in child element
2300385
@weotch
Initial srcset rendering implementation
865dc96
@weotch
Support width/height as numeric strings
fd1cff0
@weotch
Generate srcset using Next.js conventions
3719ef3
@weotch
Expand to wrapper
8b226d4
@weotch
Fix srcset syntax
a0353eb
@weotch
Rename PictureImageProps
9736316
@weotch
Test of that correct image is loaded
041568e
@weotch
Rename ReactVisualProps
95d4ebb
@weotch
Support rendering source tags from types and media
3346deb
@weotch
Add tests of VisualWrapper
fa07da4
@weotch
Wait or assets to load
c4231a2
@weotch
Add tests of natural image size
33cd243
@weotch
Test that the wrapper dimensions override natural image size
a406796
@weotch
Move commands to a shared location
a005fc1 
Had to convert to JS to silence Cyrpess TS errors
@weotch
Revert "Move commands to a shared location"
eed7b90 
This reverts commit a005fc1.
@weotch
Drop network intercepting strategy
c941437 
It was unstable
@weotch
Add docs
8f3728b
@cypress Cypress
Copy link

cypress bot commented Nov 17, 2023 •
edited
Loading

Passing run #159 ↗︎

0 18 0 0 Flakiness 0

Details:

Move test into command
Project: react-visual Commit: 5de91b4497
Status: Passed Duration: 00:12 💡
Started: Nov 17, 2023 1:32 AM Ended: Nov 17, 2023 1:32 AM

Review all test suite changes for PR #31 ↗︎

@weotch weotch merged commit ba0f360 into main Nov 17, 2023
3 checks passed
@weotch weotch deleted the react-img branch November 17, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement react-visual
1 participant
@weotch