Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused launch_vboxvm() #5842

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Remove unused launch_vboxvm() #5842

merged 1 commit into from
Oct 9, 2024

Conversation

computezrmle
Copy link
Contributor

As @davidpanderson mentioned that function is never called.

BTW, looking at the vboxwrapper code (vbox_common.cpp)
I see a function VBOX_BASE::launch_vboxvm() that's never called.
Should we remove it?

Originally posted by @davidpanderson in #5841 (comment)

@AenBleidd AenBleidd added this to the vboxwrapper v26208 milestone Oct 9, 2024
@AenBleidd AenBleidd merged commit dca4153 into BOINC:master Oct 9, 2024
146 checks passed
@computezrmle computezrmle deleted the Remove-unused-launch_vboxvm() branch October 9, 2024 09:18
AenBleidd added a commit that referenced this pull request Oct 10, 2024
@AenBleidd
Merge pull request #5842 from computezrmle/Remove-unused-launch_vboxvm()
4df18f7 
Remove unused launch_vboxvm()

Signed-off-by: Vitalii Koshura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AenBleidd AenBleidd AenBleidd approved these changes

Assignees
No one assigned
Labels
C: Apps - VboxWrapper P: Trivial PR: Enhancement
Projects
Client/Manager
Status: Merged
Milestone
vboxwrapper v26208
Development

Successfully merging this pull request may close these issues.
2 participants
@computezrmle @AenBleidd