Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOK-394 | Fix Feedback received for Inward API #52

Merged
merged 3 commits into from
Oct 11, 2023
Merged

GOK-394 | Fix Feedback received for Inward API #52

merged 3 commits into from
Oct 11, 2023

Conversation

yenugukeerthana
Copy link
Contributor

Requirements

  • This PR has a proper title that briefly describes the work done
  • I have squashed / amended the comments to make it more redable
  • I have included link to all the JIRA ticket('s)
  • I wrote the code as a pair or atleast performed a self-review of my own code
  • I have updated the documentation on Bahmni Wiki or README (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary

Screenshots

JIRA tickets

Other

yenugukeerthana and others added 2 commits October 10, 2023 18:27
@yenugukeerthana @deeptirawat1510
Fix. Feedback received for Inward API
d7623bb 
Co-authored-by: deeptirawat1510 <[email protected]>
@yenugukeerthana @deeptirawat1510
Fix. Date for Inward API
34c94db 
Co-authored-by: deeptirawat1510 <[email protected]>
riyaTw
riyaTw requested changes Oct 11, 2023
View reviewed changes
src/inventory/aushada/aushada.jsx Outdated

const notificationAction = enableEaushadhaInwardApi
? setStockEmptyResonseMessage
: setStockEmptyResonseMessage;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why both if and else condition of ternary is same here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have updated the code and removed ternary condition.

src/inventory/aushada/aushada.jsx Outdated Show resolved Hide resolved
@yenugukeerthana @deeptirawat1510
Fix. PR comments
f9ddf76 
Co-authored-by: deeptirawat1510 <[email protected]>
@yenugukeerthana yenugukeerthana merged commit 8938d66 into master Oct 11, 2023
1 check passed
@yenugukeerthana yenugukeerthana deleted the GOK-394 branch October 11, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riyaTw riyaTw riyaTw approved these changes

@sweetyTW sweetyTW Awaiting requested review from sweetyTW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yenugukeerthana @riyaTw