Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH-3969 | Add. Bahmni Embedded Tomcat v10 #140

Merged
merged 2 commits into from
Jun 21, 2024
Merged

BAH-3969 | Add. Bahmni Embedded Tomcat v10 #140

merged 2 commits into from
Jun 21, 2024

Conversation

rahu1ramesh
Copy link
Contributor

JIRA -> BAH-3969

In this PR, the following changes are introduced:

  1. Bahmni Embedded Tomcat v10: Migrating from Java 11 to Java 17 necessitates upgrading the embedded Tomcat version to at least Tomcat 10, as Tomcat 8 is not compatible with Java 17. This task involves creating, testing, and publishing a Tomcat 10 jar that can be embedded within Bahmni applications. The new jar will ensure compatibility with the updated Java runtime and provide the necessary features and security updates.
  2. Updated Workflow: This workflow should build and upload both versions of the bahmni-embedded-tomcat to AWS S3 correctly.

- name: Set up JDK 17
uses: actions/setup-java@v2
with:
distribution: 'adopt'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use corretto as our distribution to keep it consistent with other repositories

@mohan-13 mohan-13 merged commit 95ca141 into master Jun 21, 2024
3 checks passed
@mohan-13 mohan-13 deleted the BAH-3969 branch June 21, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants