Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure repo #60

Merged
merged 22 commits into from
Nov 17, 2023
Merged

Restructure repo #60

merged 22 commits into from
Nov 17, 2023

Conversation

leoqiao18
Copy link

Clean up repo:

  1. use package.yaml to replace tsl.cabal
  2. reorganize project structure to be a more traditional app (executable), src (library) and test (tests) structure
  3. remove tools and tool-utilities, and only have a single tsl command (implemented in app directory)
  4. more obvious pipeline passes

@leoqiao18 leoqiao18 self-assigned this Nov 16, 2023
@leoqiao18
Copy link
Author

leoqiao18 commented Nov 17, 2023

@santolucito Done. Can you take a look at this PR and see if the changes are ok with you? Made some drastic changes.

The new command now looks like this:

$ stack run -- tsl --help
tsl

Usage: tsl COMMAND

  TSL synthesis tool

Available options:
  -h,--help                Show this help text

Available commands:
  preprocess               TSL -> Core TSL
  theorize                 TSL -> theory-encoded Core TSL
  tlsf                     TSL -> LTL under-approximation in TLSF format
  hoa                      TSL -> synthesized controller in HOA format
  synthesize               TSL -> synthesized program in target language

@santolucito
Copy link
Member

what about these: https://github.com/Barnard-PL-Labs/tsltools/#debugging-tsl-specifications. We still need these

@leoqiao18
Copy link
Author

what about these: https://github.com/Barnard-PL-Labs/tsltools/#debugging-tsl-specifications. We still need these

I will add them in.

README.md Outdated Show resolved Hide resolved
src/TSL/Command/Synthesize.hs Show resolved Hide resolved
@leoqiao18
Copy link
Author

@santolucito I added back the functionalities of tslminrealizable and tslcoregen. The last one for debugging is tslplay, which uses the CFM stuff. Does that mean we don't need it anymore?

@santolucito
Copy link
Member

santolucito commented Nov 17, 2023 via email

@leoqiao18
Copy link
Author

so tslplay should let us "play" against a counter strategy. So it is good functionality to have in theory, though I only got it to actually work once and it wasn't easy. maybe we leave it out for this PR and open an issue that we need to revisit it

On Fri, Nov 17, 2023 at 3:35 PM Leo Qiao @.> wrote: @santolucito https://github.com/santolucito I added back the functionalities of tslminrealizable and tslcoregen. The last one for debugging is tslplay, which uses the CFM stuff. Does that mean we don't need it anymore? — Reply to this email directly, view it on GitHub <#60 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIJAPHFEVMG5XIXZ4FG6ZTYE7DCTAVCNFSM6AAAAAA7NOQYNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGA3DQNJSGI . You are receiving this because you were mentioned.Message ID: @.>

Ok, that sounds reasonable. I will update the README now, and after that can I merge this in?

@leoqiao18
Copy link
Author

Issue that will document the development of the commands: #62

@santolucito
Copy link
Member

lgtm!

@leoqiao18 leoqiao18 merged commit a80147a into master Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants