Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved debug console messages #960

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

hgraceb
Copy link
Contributor

@hgraceb hgraceb commented Jul 27, 2024

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Improved debug console messages. References from NetworkImage of flutter.

informationCollector: () => <DiagnosticsNode>[
  DiagnosticsProperty<image_provider.ImageProvider>('Image provider', this),
  DiagnosticsProperty<image_provider.NetworkImage>('Image key', key),
],

⤵️ What is the current behavior?

======== Exception caught by image resource service ================================================
The following HttpExceptionWithStatus was thrown resolving an image codec:
HttpException: Invalid statusCode: 404, uri = https://blurha.sh/assets/images/img1.jpg

When the exception was thrown, this was the stack: 
Image provider: CachedNetworkImageProvider("https://blurha.sh/assets/images/img1.jpg", scale: 1.0) 
 Image key: CachedNetworkImageProvider("https://blurha.sh/assets/images/img1.jpg", scale: 1.0): CachedNetworkImageProvider("https://blurha.sh/assets/images/img1.jpg", scale: 1.0)
====================================================================================================

🆕 What is the new behavior (if this is a feature change)?

======== Exception caught by image resource service ================================================
The following HttpExceptionWithStatus was thrown resolving an image codec:
HttpException: Invalid statusCode: 404, uri = https://blurha.sh/assets/images/img1.jpg

When the exception was thrown, this was the stack: 
Image provider: CachedNetworkImageProvider("https://blurha.sh/assets/images/img1.jpg", scale: 1.0)
Image key: CachedNetworkImageProvider("https://blurha.sh/assets/images/img1.jpg", scale: 1.0)
====================================================================================================

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

N/A

📝 Links to relevant issues/docs

N/A

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@martijn00 martijn00 merged commit 536da01 into Baseflow:develop Jul 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants