Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in_toolbox prompt to powerline themes #1716

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

likan999
Copy link
Contributor

Toolbox is an containerized development environment. This commit adds a promot to powerline when it is running inside a toolbox.

[Toolbox](https://github.com/containers/toolbox) is an containerized
development environment. This commit adds a promot to powerline when it
is running inside a toolbox.
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always glad to see enhancement to the Powerline themes.

I left a few comments for your review.

-DF


PS: As a courtesy, let's ping the creators of these pw-based themes:

themes/gitline/powerline.base.bash Outdated Show resolved Hide resolved
themes/gitline/gitline.theme.bash Outdated Show resolved Hide resolved
themes/powerline-multiline/powerline-multiline.theme.bash Outdated Show resolved Hide resolved
themes/powerline-multiline/README.md Outdated Show resolved Hide resolved
@likan999
Copy link
Contributor Author

likan999 commented Nov 29, 2020

Thanks for the quick response. Addressed the comments, and using character everywhere, which is used by toolbox itself. Please let me know different themes should show different characters. Thanks.

Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think '⬢' is a better choice all around since its used by toolbox itself and is a basic unicode character.

Looks good to me!

@NoahGorny
Copy link
Member

NoahGorny commented Dec 3, 2020

There seems to be a lot of code dup between the themes and their READMEs

I guess we should fix it in a future PR

Great work @likan999 and thanks for the review @davidpfarrell

@NoahGorny NoahGorny merged commit 929321a into Bash-it:master Dec 3, 2020
@likan999 likan999 deleted the in_toolbox branch December 5, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants