Add ci #1
Closed
Add ci #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Give prettier full reign * Made eslint more aggressive
|
To my (admittedly also fairly unfamiliar with github actions) eyes, this looks like the way to achieve what we want. Thanks for catching the needed the lint and fmt scripts, knew I was missing something in previous commits. |
|
So fun thing I just learned. You cannot change which repo a PR targets, only the branch. Closing this to open the one against the main repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CI job. Any thoughts about optimization or quality I'm all ears for since I'm unfamiliar with GH Actions. This follows the shape of many of the things we currently have.