DRAFT: Azure single peering #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that something in Azure is eventually consistent. Specifically, when we set up the express route circuit in azure and then (quickly) set up a VXC thereafter Azure seems to return an error saying that the service key (which it just gave us) is invalid. I think the error goes as described in this PlantUML ```puml @startuml participant executor participant azure participant megaport executor -> azure: create express route azure -> executor: ok, done. service key is $x executor -> megaport: provision express route with service key $x megaport -> azure : can you set up $x for me? azure -> megaport : I have never heard of $x megaport -> executor : $x is invalid service key @enduml ``` This patch ensures that the service key is valid by waiting up to 5 minutes for the service key to appear to megaport.
daniel-noland
force-pushed
the
azure-single-peering
branch
from
cb1b997 to
de4f98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions
Please read the (Contribution Guidelines)[https://github.com/megaport/terraform-provider-megaport/wiki/Contributing.md]
prior to lodging Pull Requests (PR).
Description
Please include a summary of the change and which issue is fixed. Please also include any relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Contributor Agreement
Lodging this Pull Request (PR) indicates agreement with the project's
(Contributor License Agreement)[https://github.com/megaport/terraform-provider-megaport/wiki/Megaport_Contributor_Licence_Agreement.md].
Please read the Contributor Licence Agreement (CLA) and affirm your acceptance here:
[I have read an accept the CLA]
NOTE If multiple authors have commited to this PR, each one will need to comment on this PR and
agree to the CLA before this PR can be accepted.