Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iOS 11 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for iOS 11 #2

wants to merge 2 commits into from

Conversation

ichitaso
Copy link

No description provided.

ichitaso added 2 commits August 13, 2018 00:50
Copy link
Owner

@Bensge Bensge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please look at my comments. Definitely want to get it merged 👍

}
}
else if (kCFCoreFoundationVersionNumber >= CoreFoundationiOS11) {
[[objc_getClass("WPScanRequest") alloc] setRssiThreshold:[NSNumber numberWithInt:-130]];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this method actually affect the wifi scan initiated by the system or does this only change this instance of WPScanRequest? I would assume the latter

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no change on the normal Wi-Fi setting screen. Valid only when scanning with WiPi.

if ([((__bridge NSDictionary *)userInfo)[NSLoadedClasses] containsObject:@"CCUIConnectivityAirDropViewController"]) { // The Network Bundle is Loaded
if (!didHook) {
didHook = YES;
%init(ControlCenter11);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the notification observer afterwards? Just to clean things up and not leave the notification listener active forever

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete it. It is necessary to prepare another method.

@@ -591,6 +657,28 @@ void initFlipSwitch()
%init(ControlCenter, BUTTONCLASS=(objc_getClass("SBControlCenterButton") ?: objc_getClass("CCUIControlCenterPushButton")));
}

BOOL shouldInit = NO;
if (!NSClassFromString(@"APTableCell")) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the logic here? This is not obvious to me. Why do you load the AirPort Settings bundle, if it succeeds, wait for the network bundle to be loaded?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the notification method above, you need to prepare another method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants