Merge --values-dir to --values and delete --values-dir flag to simpli… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition to 5 existing flag based input methods (values, set, set-file, set-json & set-string), the `--values-directory` (or) `-d` in short will load a directory with values YAML files to helm. Similar to the existing, this flag can be used with 3 sub-commands of helm: install, lint & upgrade. Signed-off-by: Bhargav Ravuri <[email protected]>
- Input directory to --values-directory is read recursively for YAML files. - 1 extra unit test to verify the same. Signed-off-by: Bhargav Ravuri <[email protected]>
Precedence order swap for (-d/--values-directory) and (-f/--values). A higher rank type of input when inputted later than lower or same precedence can override values. Eg.: `helm -d values.d -f values.yaml` will override values from values.yaml with that of values.d if there are common keys. Precedence order highest to least as follows. Earlier: --set-file > --set-string > --set > --set-json > -d/--values-directory > -f/--values Now: --set-file > --set-string > --set > --set-json > -f/--values > -d/--values-directory Signed-off-by: Bhargav Ravuri <[email protected]>
…fy usage and compatibility Signed-off-by: Syst3m1An0maly <[email protected]>
Syst3m1cAn0maly
force-pushed
the
values-dir
branch
from
92e43e7 to
4edd9eb
Compare
Bhargav-InfraCloud
force-pushed
the
values-dir
branch
4 times, most recently
from
2d3cb93 to
b1239a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fy usage and compatibility
What this PR does / why we need it:
This PR replaces the --values-dir flag by an extension to the --values flag so it supports directories as well as files
Special notes for your reviewer:
If applicable: