Skip to content

Commit

Permalink
Merge pull request #245 from bobleesj/pep8-line
Browse files Browse the repository at this point in the history
feat: Change default line-length to 79 characters in `black`, `flake`, and `isort` configuration files for PEP8 compatibility.
  • Loading branch information
sbillinge authored Jan 5, 2025
2 parents a273b1a + 8fdc4e1 commit 035b31e
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exclude =
build,
dist,
doc/source/conf.py
max-line-length = 115
max-line-length = 79
# Ignore some style 'errors' produced while formatting by 'black'
# https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#labels-why-pycodestyle-warnings
extend-ignore = E203
2 changes: 1 addition & 1 deletion .isort.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[settings]
# Keep import statement below line_length character limit
line_length = 115
line_length = 79
multi_line_output = 3
include_trailing_comma = True
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: sckit-package
name: scikit-package
channels:
- conda-forge
dependencies:
Expand Down
23 changes: 23 additions & 0 deletions news/line-length.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* Change default line-length to 79 characters in `black`, `flake`, and `isort` configuration files for PEP8 compatibility.

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* <news item>

**Security:**

* <news item>
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ ignore-words = ".codespell/ignore_words.txt"
skip = "*.cif,*.dat"

[tool.black]
line-length = 115
line-length = 79
include = '\.pyi?$'
exclude = '''
/(
Expand Down
2 changes: 1 addition & 1 deletion {{ cookiecutter.github_repo_name }}/.flake8
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exclude =
build,
dist,
doc/source/conf.py
max-line-length = 115
max-line-length = 79
# Ignore some style 'errors' produced while formatting by 'black'
# https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#labels-why-pycodestyle-warnings
extend-ignore = E203
2 changes: 1 addition & 1 deletion {{ cookiecutter.github_repo_name }}/.isort.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[settings]
# Keep import statement below line_length character limit
line_length = 115
line_length = 79
multi_line_output = 3
include_trailing_comma = True
2 changes: 1 addition & 1 deletion {{ cookiecutter.github_repo_name }}/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ ignore-words = ".codespell/ignore_words.txt"
skip = "*.cif,*.dat"

[tool.black]
line-length = 115
line-length = 79
include = '\.pyi?$'
exclude = '''
/(
Expand Down

0 comments on commit 035b31e

Please sign in to comment.