Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/zarr io #42

Merged
merged 19 commits into from
Nov 23, 2024
Merged

Feat/zarr io #42

merged 19 commits into from
Nov 23, 2024

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Nov 22, 2024

add more functionality to MultiscaleGroup, and a lot of tests!

@d-v-b d-v-b requested a review from dstansby November 22, 2024 16:21
@d-v-b
Copy link
Contributor Author

d-v-b commented Nov 22, 2024

I peeled from_arrays and from_array_props off the MultiscaleGroup class and put it in the tests as over-engineered test utilities. If we need these in the library, we an always bring them back.

dstansby
dstansby reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - didn't look at the tests, I trust you with them if you're happy with that (shout if you want me to properly review them though)

src/ome_zarr_models/v04/multiscales.py Show resolved Hide resolved
src/ome_zarr_models/v04/multiscales.py Outdated Show resolved Hide resolved
src/ome_zarr_models/zarr_utils/__init__.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@dstansby dstansby mentioned this pull request Nov 22, 2024
Closed
@d-v-b
Copy link
Contributor Author

d-v-b commented Nov 22, 2024

i think this is ready to go, any further thoughts / concerns @dstansby ?

dstansby
dstansby approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, feel free to resolve as you see fit then merge 🚢

src/ome_zarr_models/v04/multiscales.py Show resolved Hide resolved
@dstansby dstansby merged commit 20536c8 into BioImageTools:main Nov 23, 2024
3 checks passed
@d-v-b d-v-b deleted the feat/zarr-io branch November 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-v-b @dstansby