Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store and restore screen settings cross reboots #323

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KaSt
Copy link

@KaSt KaSt commented Feb 13, 2024

Hello,
I'm taking liberty to submit to your review and consideration the following pull request.
I have a few boards running this little gem of software but some are not running all the time. Hence I thought it could have been useful to restore the latest orientation and screen "cycle" selection. Could only test it on T-Display and QT Pro.

Thanks for your great work, de verdad me gusta un monton!

@BitMaker-hub
Copy link
Owner

Thanks for your PR, this is something a lot of people requested.
I'll try to merge the following week with the other PRs

@dwightmulcahy
Copy link
Contributor

So I pulled and tried this on a LILYGO T-Display-S3 and it messed up the orientation of the screen (portrait vs landscape). :/

@KaSt
Copy link
Author

KaSt commented Mar 13, 2024 via email

@sany3001
Copy link
Contributor

sany3001 commented Mar 13, 2024

I am still no more able to build my project.

Compiling .pio/build/TTGO-T-Display/src/ShaTests/nerdSHA256plus.cpp.o
In file included from /home/jiri/.platformio/packages/toolchain-xtensa-esp32/xtensa-esp32-elf/sys-include/sys/reent.h:503,
                 from /home/jiri/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32/include/newlib/platform_include/sys/reent.h:17,
                 from /home/jiri/.platformio/packages/toolchain-xtensa-esp32/xtensa-esp32-elf/sys-include/stdio.h:60,
                 from src/ShaTests/nerdSHA256.cpp:2:
/home/jiri/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32/include/newlib/platform_include/assert.h:20:10: fatal error: sdkconfig.h: No such file or directory

This file really not exists in my local project. I am not aware I have deleted this. Building for T-Display.

@BitMaker-hub
Copy link
Owner

I think I need to merge the actual PRs and make a little bit clean on the project.
I'm finishing an update on NerdAxe repo, when I finish it this week I'll start the cleaning

@julio-matarranz
Copy link
Collaborator

I think I need to merge the actual PRs and make a little bit clean on the project. I'm finishing an update on NerdAxe repo, when I finish it this week I'll start the cleaning

Thank you @BitMaker-hub
I have two questions :

  1. Is there a Discord or did you plan to make one ?
  2. Have you considered to grant some reviewers on NerdMiner to help you ?

@dwightmulcahy
Copy link
Contributor

Please don't merge this PR; it still needs work on the other devices as evident by it not working on the LILYGO T-Display-S3.

@BitMaker-hub
Copy link
Owner

@julio-matarranz
1- I didn't have a Discord for this project, but we could think about it
2- Could you reach me at telegram or any other platform to talk abou it? I think is interesting too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants