Skip to content

Commit

Permalink
upgrade node to v20
Browse files Browse the repository at this point in the history
  • Loading branch information
BitPatty committed Oct 27, 2023
1 parent 78fe868 commit c107d19
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 39 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Update the VARIANT arg in docker-compose.yml to pick a Node version: 10, 12, 14
ARG VARIANT=16
ARG VARIANT=20
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}

# See https://github.com/microsoft/vscode-dev-containers/tree/master/containers/docker-from-docker for more documentation
Expand Down
71 changes: 35 additions & 36 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,42 +3,41 @@
"dockerComposeFile": "docker-compose.yml",
"service": "application",
"workspaceFolder": "/workspace",
"settings": {
"terminal.integrated.defaultProfile.linux": "bash"
"customizations": {
"vscode": {
"settings": {
"terminal.integrated.defaultProfile.linux": "bash"
},
"remoteEnv": {
"PATH": "${containerEnv:PATH}:/workspace/bin"
},
"extensions": [
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"mikestead.dotenv",
"ms-azuretools.vscode-docker",
"ms-vsliveshare.vsliveshare",
"wayou.vscode-todo-highlight",
"xshrim.txt-syntax"
]
}
},
"remoteEnv": {
"PATH": "${containerEnv:PATH}:/workspace/bin"
},
"extensions": [
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"mikestead.dotenv",
"ms-azuretools.vscode-docker",
"ms-vsliveshare.vsliveshare",
"wayou.vscode-todo-highlight",
"xshrim.txt-syntax"
],
"forwardPorts": [
3000,
4000,
9000,
9001
],
"forwardPorts": [3000, 4000, 9000, 9001],
"postCreateCommand": "bash -i .devcontainer/init.sh",
"remoteUser": "node",
"portsAttributes": {
"3000":{
"label": "Example Application",
"onAutoForward": "notify"
},
"4000": {
"label": "Imgproxy Server"
},
"9000": {
"label": "Minio Server"
},
"9001": {
"label": "Minio Console"
}
"remoteUser": "node",
"portsAttributes": {
"3000": {
"label": "Example Application",
"onAutoForward": "notify"
},
"4000": {
"label": "Imgproxy Server"
},
"9000": {
"label": "Minio Server"
},
"9001": {
"label": "Minio Console"
}
}
}
}
2 changes: 1 addition & 1 deletion .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
context: .
dockerfile: Dockerfile
args:
VARIANT: 14
VARIANT: 20
USER_UID: 1000
USER_GID: 1000
networks:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.16.0
v20.9.0

0 comments on commit c107d19

Please sign in to comment.