Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix icon link + 2 small bug fixes #320

Merged
merged 4 commits into from
Nov 10, 2024
Merged

fix icon link + 2 small bug fixes #320

merged 4 commits into from
Nov 10, 2024

Conversation

manulera
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (989e76e) to head (f060730).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   93.00%   93.63%   +0.63%     
==========================================
  Files          40       40              
  Lines        3744     3926     +182     
  Branches      562      589      +27     
==========================================
+ Hits         3482     3676     +194     
+ Misses        217      198      -19     
- Partials       45       52       +7     
Files with missing lines Coverage Δ
src/pydna/amplify.py 98.67% <100.00%> (+0.01%) ⬆️
src/pydna/tm.py 96.92% <100.00%> (-3.08%) ⬇️

... and 10 files with indirect coverage changes

@manulera
Copy link
Collaborator Author

Hi @BjornFJohansson this is a small fix of the icon link. Because it's to the master branch it requires your approval

@manulera manulera changed the title fix icon link fix icon link + 2 small bug fixes Nov 7, 2024
@manulera
Copy link
Collaborator Author

manulera commented Nov 7, 2024

I added a few small fixes:

#324
#325
#326

Copy link
Owner

@BjornFJohansson BjornFJohansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok! Thanks for the extra tests.

@BjornFJohansson
Copy link
Owner

Do we merge?

@manulera manulera merged commit f1702e5 into master Nov 10, 2024
37 checks passed
@manulera manulera deleted the dev_bjorn branch November 10, 2024 08:37
@manulera
Copy link
Collaborator Author

@BjornFJohansson can you make a pre-release for pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants